Friday, March 8, 2019

What to look for in code review


From the "Code Review Best Practices" post from Trisha Gee

What to look for section from slide:

- Fit with the overall architecture
- SOLID principles, Domain Driven Design, Design Patterns or other paradigms of choice
- New code follows team’s current practices
- Code is in the right place
- Code reuse
- Over-engineering
- Readable code and tests
- Testing the right things
- Exception error messages
- Subtle bugs
- Security
- Regulatory requirements
- Performance
- Documentation and/or help files been updated
- Spelling, punctuation & grammar on user messages